httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Stoddard" <b...@wstoddard.com>
Subject Re: mod_asis handler bug
Date Fri, 27 Jul 2001 20:26:46 GMT
But if the file is sent by sendfile, the system filepointer is useless. We -must- pass the
correct offset into apr_bucket_file_create().

Bill

> There another bug lurking in mod_asis (reported by Ken Bruinsma in IBM). We are creating
> the file bucket with file offset of 0.  Problem is that we have already read in part
of
> the file (the headers) a bit earlier. Need to give some thought to the best way to fix
> this (and what all the implications are).
>
> Perhaps pass in a -1 for offset on the apr_bucket_file_create() when we want to rely
on
> the system file pointer? Which reminds me that I still need to look at the apr_file_seek
> issue Cliff, Ryan and I were discussing a few weeks past.
>
> Cliff, I am about out of time today so if you want to pursue this, be my guest:-)
>
> Bill
>
>
> ----- Original Message -----
> From: "Cliff Woolley" <cliffwoolley@yahoo.com>
> To: <new-httpd@apache.org>
> Sent: Friday, July 27, 2001 3:40 PM
> Subject: Re: mod_asis handler bug
>
>
> > On Fri, 27 Jul 2001, Bill Stoddard wrote:
> >
> > > What Ryan is suggesting is slightly different than what either of us
> > > has proposed.
> >
> > Yeah... that's because I never proposed it.  But I _had_ been thinking it
> > needed to be done.  :)
> >
> > I did a recursive grep a few days ago for ap_send_fd... it's currently
> > only being used by mod_asis, which is good.  Apache itself should just
> > about never use it, since we almost always have more work to do (eg
> > flushing the brigade, sending other stuff down the chain, etc), which
> > makes it more efficient if we build the brigade on our own.  ap_send_fd()
> > is the quick-and-dirty, old-api-compatible way to do it.
> >
> > >  His suggestion sends down the eos, not a flush.  Will
> > > commit this in a few.
> >
> > Have at it!  =-)
> >
> > --Cliff
> >
> > --------------------------------------------------------------
> >    Cliff Woolley
> >    cliffwoolley@yahoo.com
> >    Charlottesville, VA
> >
> >
>


Mime
View raw message