httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Stoddard" <b...@wstoddard.com>
Subject Re: mod_asis handler bug
Date Fri, 27 Jul 2001 19:09:24 GMT
What Ryan is suggesting is slightly different than what either of us has proposed.  His
suggestion sends down the eos, not a flush.  Will commit this in a few.

Bill

> On Fri, 27 Jul 2001, Ryan Bloom wrote:
>
> >
> > Why not just re-write it to make more sense?
> >
> > apr_file_open()
> > apr_bucket_file_create()
> > apr_brigade_create()
> > APR_BUCKET_INSERT_HEAD()
> > apr_bucket_eos_create()
> > APR_BUCKET_INSERT_TAIL()
> > ap_pass_brigade()
> > return OK
>
> I was going to do that anyway.  But to get what's there working with the
> fewest number of lines changed, all that has to happen is to - the
> apr_file_close() lines.
>
> I didn't make the change to the above because I wasn't sure what the
> behavior would be within the 'asis' concept and whether it would work as
> expected with filters in the chain and all.  But then again all that
> ap_send_fd() is doing under the covers is the above anyway, so it doesn't
> really make a difference.
>
>
> --------------------------------------------------------------
>    Cliff Woolley
>    cliffwoolley@yahoo.com
>    Charlottesville, VA
>
>


Mime
View raw message