httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Stoddard" <b...@wstoddard.com>
Subject Re: cvs commit: httpd-2.0/modules/generators mod_cgi.c mod_cgid.c
Date Mon, 30 Jul 2001 16:17:13 GMT
> > stoddard    01/07/30 08:11:40
> >
> >   Modified:    .        CHANGES
> >                modules/generators mod_cgi.c mod_cgid.c
> >   Log:
> >   Win32: Get exec cgi tag working.  finfo.protection == 0 on Windows from the
> >   apr_stat() call in directory walk (because discovering the permissions on
> >   Windows is ridiculously expensive).  All we really need to know is whether the
> >   file exists.
>
> Wouldn't it make more sense, in this context, to give up if
> rr->finfo.filetype != APR_FILE?

My first cut was indeed checking filetype != APR_FILE, then I thought about the APR_LNK
issue...

> It's the responsibility of
> dir walk/file walk to resolve symlinks to their target, so
> we shouldn't have to test APR_LNK.

Cool! Didn't recognise this.


Bill



Mime
View raw message