Mailing-List: contact new-httpd-help@apache.org; run by ezmlm
Precedence: bulk
Reply-To: new-httpd@apache.org
Date: Thu, 14 Jun 2001 03:17:52 -0700
From: Greg Stein <gstein@lyra.org>
To: new-httpd@apache.org
Subject: Re: [PATCH] mgmt_get_vars hook
Message-ID: <20010614031751.N31504@lyra.org>
Mail-Followup-To: new-httpd@apache.org
References: <3482305AF0F6CF469ED45C0D48FAFCF7091FF4ED@cnet48.cnet.com>
 <20010613131156.B31504@lyra.org> <3B27DA36.4C0BC0D2@covalent.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2i
In-Reply-To: <3B27DA36.4C0BC0D2@covalent.net>;
 from harrie@covalent.net on Wed, Jun 13, 2001 at 02:25:10PM -0700

Three +1 votes are not required for commits like this. That is really only
needed when you have "big" functionality, or you make large (design) changes
to the system. Most everything else is commit-then-review.

I committed the code because it looked just right to me. With it in source
control, we can refine it if necessary. But even better: we can build on it
now.

Discussion is never "closed" on any of the code. If you have a better way,
then we can continue discussing. But I have to say, I believe the hook is
the absolute right answer (it frees all endpoints from knowing about the
others), and I think human-recognizable strings for names is appropriate. I
also liked the set of types available for each item (integer, string, or a
(sub) hash table)

Cheers,
-g

On Wed, Jun 13, 2001 at 02:25:10PM -0700, Harrie Hazewinkel wrote:
> Greg Stein wrote:
> > 
> > On Wed, Jun 13, 2001 at 08:27:31AM -0700, Ian Holsman wrote:
> > > [Latest Rev Of patch with the hook changed to RUN_ALL]
> > 
> > I've applied this with some reasonably heavy changes. Watch for the CVS
> > commit email.
> 
> Hmm, I worry here about the process. If someone who has no commit
> access wants to have things in or have things changed it
> always creates a problem. If someone with commit access
> this is good enough he just can commit it.
> 
> If I counted well I only saw 1 times a '+1' on the
> concept where 3 are needed. I also believe that some things
> still need to change for this issue and we were not
> done discussing it.
> 
> 
> Harrie
> -- 
> address: Covalent Technologies, 645 Howard St, San Francisco, CA - 94105
> phone: +1-415-536-5221                               fax:+1-415-536-5210
> personal website: http://www.lisanza.net/

-- 
Greg Stein, http://www.lyra.org/