Mailing-List: contact new-httpd-help@apache.org; run by ezmlm
Precedence: bulk
Reply-To: new-httpd@apache.org
Date: Thu, 7 Jun 2001 03:35:26 -0700
From: Greg Stein <gstein@lyra.org>
To: dev@apr.apache.org
Cc: new-httpd@apache.org
Subject: Re: cvs commit: apr-util/buckets apr_buckets.c apr_buckets_eos.c
 apr_buckets_flush.c apr_buckets_heap.c apr_buckets_simple.c
Message-ID: <20010607033526.J23560@lyra.org>
Mail-Followup-To: dev@apr.apache.org, new-httpd@apache.org
References: <20010607101343.96610.qmail@apache.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2i
In-Reply-To: <20010607101343.96610.qmail@apache.org>;
 from gstein@apache.org on Thu, Jun 07, 2001 at 10:13:43AM -0000

With this change, we can start implementing the setaside() function for
FILE, MMAP, PIPE, SOCKET, and POOL. The FILE would probably be handiest to
test out the subrequest stuff, followed by POOL then MMAP.

Note there are some future changes to do in ap_save_brigade(); I've left
comments to that effect.

Cheers,
-g

On Thu, Jun 07, 2001 at 10:13:43AM -0000, gstein@apache.org wrote:
> gstein      01/06/07 03:13:43
> 
>   Modified:    server   util_filter.c
>                include  apr_buckets.h
>                buckets  apr_buckets.c apr_buckets_eos.c apr_buckets_flush.c
>                         apr_buckets_heap.c apr_buckets_simple.c
>   Log:
>   *) Add apr_bucket_setaside_noop to use for buckets that do not require a
>      setaside function. It simply returns APR_SUCCESS.
>      - adjust the EOS, FLUSH, IMMORTAL, and HEAP buckets to use _noop.
>   
>   *) Make the setaside() function take a pool to define the (new) lifetime for
>      the bucket's data.
>      - Adjust the apr_bucket_setaside() macro.
>      - Adjust the apr_bucket_setaside_notimpl() and transient_setaside()
>        functions.
>      - Pass the additional parameter in ap_save_brigade()
>   
>   *) Update docs for setaside()
>   
>   *) Minor nit with macros in apr_buckets.h: add parens for binding safety.
>...

-- 
Greg Stein, http://www.lyra.org/