httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From <...@covalent.net>
Subject Re: [PATCH] mgmt_get_vars hook (was RE: Hooks for management reportin g)
Date Mon, 11 Jun 2001 22:46:29 GMT

A few things:

1)  Can you post patches in-line please, it makes them much easier to
reply to.

2)  Why are we using a hash instead of a table?  If this is all string
based, I believe a table will be much easier to deal with, plus we can
iterate through a table.

3)  Why is this a RUN_FIRST instead of a RUN_ALL?

Ryan

On Mon, 11 Jun 2001, Ian Holsman wrote:

> Ok..
> Part 1.. adding the hook
>
> once this gets approved/commited
> I'll work on implementing the hook in scoreboard and the mpm's
>
> > -----Original Message-----
> > From: Greg Stein [mailto:gstein@lyra.org]
> > Sent: Monday, June 11, 2001 2:36 AM
> > To: new-httpd@apache.org
> > Subject: Re: Hooks for management reporting
> >
> >
> > On Sun, Jun 10, 2001 at 09:36:34PM -0700, Ian Holsman wrote:
> > > how about this prototype?
> > >
> > > it registers a 'test' hook which generates somes values,
> > > I envison that this would be similliar to how the this would work
> > > for the 'get/walk' type commands
> >
> > Looks good to me. It's got the flexibility of typing info
> > that allows us to
> > do structured data. The dotted naming is also a nice way to
> > ask for specific
> > bits, groups, or everything.
> >
> > +1 on concept.
> >
> > I believe a patch would only define the hook (and
> > corresponding header doc).
> > Note that I think the mgmt_line_t would be part of the
> > system, so it would
> > be in the patch, too. The C code would probably go into
> > server/core.c since
> > this is independent of MPMs (yes, they can use it, but all
> > kinds of stuff in
> > the server can use it).
> >
> > A second patch round can consider how this might be integrated into
> > mod_status, and a third round for switching the scoreboard
> > <-> mod_status
> > communication channel.
> >
> > >...
> > > > From: Harrie Hazewinkel [mailto:harrie@lisanza.net]
> > > > Sent: Sunday, June 10, 2001 11:35 AM
> > > > To: new-httpd@apache.org
> > > > Subject: Re: Hooks for management reporting (was RE:New Hook)
> > >...
> > > > > #2 I usually need to see more generic stuff, and will
> > probably shove the
> > > > > values in a database/rrd so I can make pretty reports
> > > >
> > > > IMHO, making pretty reports is part of the management
> > application and
> > > > should not be done on an operational system. The only
> > thing you need
> > > > is enough information to create the report.
> >
> > Just had to respond to this one point...
> >
> > The reporting *can* be done on an operational system. That
> > isn't for us to
> > decide for users. This hook allows for the info to be
> > offloaded from the
> > box, or to generate the info right within the server process.
> >
> > Cheers,
> > -g
> >
> > --
> > Greg Stein, http://www.lyra.org/
> >
>
>


_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message