httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From <...@covalent.net>
Subject Re: cvs commit: httpd-2.0/modules/http http_request.c
Date Fri, 01 Jun 2001 20:37:00 GMT

> > > Ok - so to sum up basically reset_filters() should remove all filters
> > > from the stack, then add the three minimal basic filters, and run with
> > > it from there...?
> >
> > Yep.  Just makes the code easier by removing a bunch of if's.  It also
> > makes it very obvious just what the required filters are.  If we ever need
> > to add another required filter, it just gets added right there.
>
> Then simplify the code even more:
>
> void reset_filters(request_rec *r)
> {
>     r->output_filters = NULL;
>     ap_add_output_filter("CORE", NULL, r, r->connection);
>     ap_add_output_filter("CONTENT_LENGTH", NULL, r, r->connection);
>     ap_add_output_filter("HTTP_HEADER", NULL, r, r->connection);
> }

Yep, even better.

> I'm wondering what would happen if we had already sent data out. That would
> be icky... but I guess we alrady have that problem today (and in 1.3).

We can't have already sent data.  We are talking about an HTTP error, and
by definition, if we have already sent data, we can't send an HTTP error
response.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message