httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cliff Woolley <cliffwool...@yahoo.com>
Subject Re: [PATCH] Add back -X functionality
Date Thu, 21 Jun 2001 15:59:28 GMT
On Thu, 21 Jun 2001 rbb@covalent.net wrote:

> The !! was there by the way, because it solved a lot of bugs on many
> platforms.

I'd wondered about that myself.  I guess doing !! ensures that the value
is 0 or 1 and not 0 or non-zero?  Whatever.

> In all, I am -0.9 for this patch, I won't veto it, but I don't want to see
> it in the code.  If we do put the -X back in, then remove -DONE_PROCESS.
> Having both is just bogus.

That may be, but IMHO it completely violates the principle of least
astonishment to have -X vaporize.  I wanted to use it one day a month or
so ago, got an error message that it was an unknown flag [with no hint
that it'd changed to -DONE_PROCESS] and had to actually go dig into the
MPM source to figure out how to tell Apache what to go do with itself.
To me, THAT'S bogus.  At the very least, -X should give a hint that it's
now -DONE_PROCESS or it should be really well documented somewhere
(AFAICT, it's not currently documented... may be wrong about that).

Anyhow, I'm +1 on concept [sans the !! stuff].

--Cliff

--------------------------------------------------------------
   Cliff Woolley
   cliffwoolley@yahoo.com
   Charlottesville, VA



Mime
View raw message