httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Marr <gr...@alum.wpi.edu>
Subject Re: Tagging tree tonight.
Date Wed, 27 Jun 2001 22:08:41 GMT
At 05:34 PM 06/27/2001, William A. Rowe, Jr. wrote:
> > At 05:08 PM 06/27/2001, Bill Stoddard wrote:
> > >Hold off. There is a serious bug in the APR MMAP code on Windows
> > >that is breaking things.
> > >The offending code from mmap.c is here:
> > >
> > >     offhi = (DWORD)((*new)->psize << 32);
> >
> > This should be >> instead of <<.
> >
> > #define HIWORD(l)           ((WORD)((DWORD_PTR)(l) >> 16))
> >
> > so HIDWORD(l) would be l >> 32
>
>DWORD's are 32 bits.  apr_off_t is 64 bits.

Right, so when you want the top 32 bits of the 64 bit value, you 
shift right 32 bits.  (The HIWORD quote was just an analogy).


-- 
Greg Marr
gregm@alum.wpi.edu
"We thought you were dead."
"I was, but I'm better now." - Sheridan, "The Summoning"


Mime
View raw message