httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aaron Bannert <aa...@ebuilt.com>
Subject Re: [PATCH] Add back -X functionality
Date Thu, 21 Jun 2001 16:11:12 GMT
On Thu, Jun 21, 2001 at 08:51:47AM -0700, rbb@covalent.net wrote:
> On Thu, 21 Jun 2001, Justin Erenkrantz wrote:
> 
> > This attempts to add the -X functionality back into Apache 2.0.
> > I chose the simplest way of implementing this - have -X define a config
> > symbol called DEBUG (and you could use -DDEBUG as well).  If the MPMs
> > detect this symbol, it should do whatever is necessary for DEBUG mode
> > (which isn't necessarily ONE_PROCESS).  ONE_PROCESS and NO_DETACH are
> > still available.
> >
> > This patch also removes the !! in the ap_exists_config_define calls
> > as I can't fathom what that is good for.
> >
> > Comments and suggestions welcomed.  -- justin
> 
> As I said when this was originally discussed, I really dislike this.  -X
> is the exact same as -DONE_PROCESS.  We now have two ways to get into the
> same state.  Yuck!  We made a conscious decision to go with -DONE_PROCESS,
> the original goal being to move towards environment variables instead of
> command line arguments.  The !! was there by the way, because it solved a
> lot of bugs on many platforms.

*eeww* There really was a group movement toward environment variables?
Could you perhaps point me to this thread?

(Env vars are bad, IMHO. It's not fun to debug an application for hours
only to find out that the unexplained behavior was caused by some
obscure/undocumented env var)


p.s. why would "!!" fix bugs on some platforms if ap_exists_config_define
can only return 0 or 1? I can only see using !! to normalize some non-bool
return to 0/1 for some weird logic, and even then it's not readable.


> In all, I am -0.9 for this patch, I won't veto it, but I don't want to see
> it in the code.  If we do put the -X back in, then remove -DONE_PROCESS.
> Having both is just bogus.

-aaron


Mime
View raw message