httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: [PATCH] mgmt_get_vars hook
Date Tue, 12 Jun 2001 00:50:57 GMT
On Mon, Jun 11, 2001 at 03:46:29PM -0700, rbb@covalent.net wrote:
> 
> A few things:
> 
> 1)  Can you post patches in-line please, it makes them much easier to
> reply to.

Agreed. Or at *least* mark them as text/plain rather than application/*

> 2)  Why are we using a hash instead of a table?  If this is all string
> based, I believe a table will be much easier to deal with, plus we can
> iterate through a table.

It was initially a table. I asked for it to be a hash. The hash is faster
and (yes) we can iterate through it. The mgmt/status data will not be purely
string-based; the hash allows us to put integers, substructures, etc, into
the hash table. A plain table cannot do that.

(consider some module implementing counters of some kind; nicer to just pass
 integers rather than having to convert them to strings all the time; and
 substructures just couldn't be done)

> 3)  Why is this a RUN_FIRST instead of a RUN_ALL?

If the mgmt function runs the hooks and askes for "apache.dav.*", then
mod_dav can satisfy the hook and terminate the scan.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message