httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: httpd-2.0/support Makefile.in
Date Thu, 07 Jun 2001 10:32:20 GMT
On Thu, Jun 07, 2001 at 10:03:31AM -0000, orlikowski@apache.org wrote:
> orlikowski    01/06/07 03:03:30
> 
>   Modified:    .        CHANGES configure.in
>                modules/mappers mod_so.c
>                server   .cvsignore Makefile.in
>                .        configure.in
>                include/arch/unix networkio.h
>                network_io/unix poll.c
>                support  Makefile.in

You accidentally slipped in some kqueue work with this.

[ when will people stop doing a commit from the top of their tree without
  specifying the files? it seems every couple months, somebody goes to the
  top of their tree and does "cvs commit" and we end up with random stuff
  going in... sigh :-) ]


Also, shouldn't the old httpd.exp be removed?

>...
>   --- Makefile.in	2001/06/06 19:37:06	1.46
>   +++ Makefile.in	2001/06/07 10:03:13	1.47
>   @@ -1,7 +1,7 @@
>    
>    TARGET_EXPORTS    = apache.exports
>    CLEAN_TARGETS = gen_test_char test_char.h gen_uri_delims uri_delims.h \
>   -	$(TARGET_EXPORTS) ApacheCoreOS2.def
>   +	$(TARGET_EXPORTS) ApacheCoreOS2.def httpd.exp
>    EXTRACLEAN_TARGETS = exports.c
>    
>    SUBDIRS = mpm
>   @@ -16,7 +16,7 @@
>    	util_filter.c exports.c buildmark.c scoreboard.c \
>    	error_bucket.c protocol.c core.c request.c
>    
>   -TARGETS = delete-exports $(LTLIBRARY_NAME) $(CORE_IMPLIB_FILE)
>   +TARGETS = delete-exports $(LTLIBRARY_NAME) $(CORE_IMPLIB_FILE) httpd.exp

It would be nice to generate this only for the AIX platform. i.e. create a
configure rule to substitute this in when needed. Something like:

  TARGETS = ... @EXP_TARGET@

configure.in would leave it blank, or insert httpd.exp

>...
>   --- Makefile.in	2001/05/18 00:48:57	1.15
>   +++ Makefile.in	2001/06/07 10:03:29	1.16
>   @@ -12,7 +12,7 @@
>    
>    install:
>    	@test -d $(bindir) || $(MKINSTALLDIRS) $(bindir)
>   -	@cp -p httpd.exp $(bindir)
>   +	@cp -p $(top_srcdir)/server/httpd.exp $(bindir)
>    	@cp -p apachectl $(bindir)
>    	chmod 755 $(bindir)/apachectl
>    	@if test -f $(builddir)/apxs; then \

Hmm. Now that httpd.exp is no longer in support, shouldn't its installation
be handled by a different makefile?

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message