httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <ad...@rowe-clan.net>
Subject Re: Tagging the tree: 2 Showstoppers
Date Thu, 28 Jun 2001 01:25:57 GMT
From: "William A. Rowe, Jr." <admin@rowe-clan.net>
Sent: Wednesday, June 27, 2001 6:32 PM


> Folks,
> 
>   first, would some else verify that autoindex and negotiation now work properly
> from cvs/head in Apache 2.0?  Also, would someone else comment on my observation
> below?  Once those are gone, I'm all for tagging 2.0.19.

Any takers?

> ----- Original Message ----- 
> From: "William A. Rowe, Jr." <wrowe@rowe-clan.net>
> To: <new-httpd@apache.org>
> Sent: Wednesday, June 27, 2001 4:30 PM
> Subject: Fw: cvs commit: httpd-2.0/server request.c
> 
> 
> > >   --- request.c 2001/06/27 20:44:00 1.9
> > >   +++ request.c 2001/06/27 20:46:52 1.10
> > >   +    fill_in_sub_req_vars(rnew, r, next_filter);
> > >    
> > >        rnew->per_dir_config = r->server->lookup_defaults;
> > 
> > This assignment only occured in ap_sub_req_method_uri(), shouldn't this
> > also occur for ap_sub_req_lookup_file/dirent() ???

This has been so since fielding's 1.1, and it's cool... we choose one of two flavors
of initializing rnew->per_dir_config later on in apr_sub_req_lookup_file and we take
that alternate tact for apr_sub_req_lookup_dirent.  No problem here.


> > >   +    fill_in_sub_req_vars(rnew, r, next_filter);
> > >    
> > >        rnew->chunked        = r->chunked;
> > 
> > This assignment only occured in ap_sub_req_lookup_file(), shouldn't it
> > also occur for ap_sub_req_method_uri?!?

rbb ... this is you, http_request.c 1.16;
Fix some remaining problems with SSI's and Windows.  Basically, the
sendfile stuff doesn't work properly with chuncked data.
Submitted by:	Allan Edwards
Reviewed by:	Ryan Bloom



Mime
View raw message