Return-Path: Delivered-To: apmail-new-httpd-archive@apache.org Received: (qmail 87345 invoked by uid 500); 19 May 2001 00:39:03 -0000 Mailing-List: contact new-httpd-help@apache.org; run by ezmlm Precedence: bulk Reply-To: new-httpd@apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list new-httpd@apache.org Received: (qmail 87322 invoked from network); 19 May 2001 00:39:02 -0000 X-Authentication-Warning: kurgan.lyra.org: gstein set sender to gstein@lyra.org using -f Date: Fri, 18 May 2001 17:43:38 -0700 From: Greg Stein To: new-httpd@apache.org Subject: Re: Allowing modules to add input filters is broken Message-ID: <20010518174337.K6482@lyra.org> Mail-Followup-To: new-httpd@apache.org References: <3B05AB95.68A209DB@sharp.fm> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2i In-Reply-To: <3B05AB95.68A209DB@sharp.fm>; from minfrin@sharp.fm on Sat, May 19, 2001 at 01:09:09AM +0200 X-URL: http://www.lyra.org/greg/ X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N On Sat, May 19, 2001 at 01:09:09AM +0200, Graham Leggett wrote: >... > If the result of the request returns a body, then HeaderOut works great. > If however the result is 304 Not Modified, there is no body, and the > output filter never runs and we're back to the same problem we had with > the input filters. > > So the question is - which hook should be called to fiddle with the > headers after the content generator runs, but before the headers are > sent to the network, whether a body exists or not...? The output filters should *always* run, if at least to send an EOS bucket. That EOS is actually what triggers the delivery of the headers to the network (or at least to the CORE filter for output buffering into the next request). So if you're not seeing output filters run, then a bug exists. (IOW: theory says you're doing the right thing) Cheers, -g -- Greg Stein, http://www.lyra.org/