Return-Path: 
 <new-httpd-return-16338-apmail-new-httpd-archive=apache.org@apache.org>
Delivered-To: apmail-new-httpd-archive@apache.org
Received: (qmail 55765 invoked by uid 500); 21 May 2001 22:15:18 -0000
Mailing-List: contact new-httpd-help@apache.org; run by ezmlm
Precedence: bulk
Reply-To: new-httpd@apache.org
list-help: <mailto:new-httpd-help@apache.org>
list-unsubscribe: <mailto:new-httpd-unsubscribe@apache.org>
list-post: <mailto:new-httpd@apache.org>
Delivered-To: mailing list new-httpd@apache.org
Received: (qmail 55737 invoked from network); 21 May 2001 22:15:13 -0000
X-Authentication-Warning: khk.allafrica.com: khkramer set sender to
 kwindla@allafrica.com using -f
From: Kwindla Hultman Kramer <kwindla@allafrica.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <15113.37721.925123.788744@khk.allafrica.com>
Date: Mon, 21 May 2001 18:14:49 -0400
To: new-httpd@apache.org
Cc: <modproxy-dev@apache.org>
Subject: Re: mod_proxy patches for HTTP Header manipulation
In-Reply-To: 
 <Pine.GSO.4.31.0105211440020.16571-100000@garibaldi.commerce.ubc.ca>
References: <15113.34993.825009.476396@khk.allafrica.com>
	<Pine.GSO.4.31.0105211440020.16571-100000@garibaldi.commerce.ubc.ca>
X-Mailer: VM 6.87 under Emacs 20.7.1
X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N


Joshua Slive writes:
 > On Mon, 21 May 2001, Kwindla Hultman Kramer wrote:

 > > RequestHeader  set  Language  fr  %{HTTP_HOST}  ^fr
 > >
 > 
 > Just before people go wild with this sort of thing, please consider
 > not inventing a new syntax for conditional directives.  We already
 > have CustomLog/Allow/Deny which get along well with the env=
 > syntax, as in:
 > 
 > SetEnvIf Host ^fr french
 > RequestHeader set Lanuage fr env=french
 > 
 > (I don't have much sympathy for the "all in one directive" argument when
 > there is existing code and knowledge that can be more efficiently used.)
 > 

Absolutely. I stand corrected. As far as conditionals go, an 'env='
syntax does everything I would want, and is much more consistent with
other modules. (It would solve Ian's problem, for example.)

To push this a little further: it could be nice to be able to use both
environment variables and mod_rewrite-style connection info variables
as part of the Header directive's set-string. Perhaps something like:

  RequestHeader  set  Language         %{ENV:fr}
  RequestHeader  set  X-Forwarded-For  %{REMOTE_ADDR}

Is this more reasonable than my last suggestion <laugh>.

Kwindla