httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cliff Woolley <cliffwool...@yahoo.com>
Subject Re: cvs commit: httpd-2.0/server core.c
Date Tue, 01 May 2001 19:20:36 GMT
On 1 May 2001 gstein@apache.org wrote:

>   @@ -3153,6 +3155,17 @@
>                        apr_size_t n;
>
>                        rv = apr_bucket_read(bucket, &str, &n, APR_BLOCK_READ);
>   +
>   +                    /* This apr_brigade_write does not use a flush function
>   +                       because we assume that we will not write enough data
>   +                       into it to cause a flush. However, if we *do* write
>   +                       "too much", then we could end up with transient
>   +                       buckets which would suck. This works for now, but is
>   +                       a bit shaky if changes are made to some of the
>   +                       buffering sizes. Let's do an assert to prevent
>   +                       potential future problems... */
>   +                    AP_DEBUG_ASSERT(AP_MIN_BYTES_TO_WRITE <
>   +                                    APR_BUCKET_BUFF_SIZE);
>                        apr_brigade_write(ctx->b, NULL, NULL, str, n);
>                    }
>                    apr_brigade_destroy(b);

Ummm...

>From http_core.h:
#define AP_MIN_BYTES_TO_WRITE  8192

>From apr_buckets.h:
#define APR_BUCKET_BUFF_SIZE 8192

Should the assertion be less-than-or-equal instead of less-than?  AFAICT,
it should fail as is.

--Cliff


--------------------------------------------------------------
   Cliff Woolley
   cliffwoolley@yahoo.com
   Charlottesville, VA



Mime
View raw message