httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From <...@covalent.net>
Subject Re: cvs commit: httpd-2.0/server core.c
Date Tue, 01 May 2001 22:32:48 GMT

> To clarify what I'm trying to say:
>
> Let's say that we have 200 bytes of headers and a 500 byte file. If we just
> key off of the file, then we'd end up doing a sendfile with 700 bytes total
> content. Bummer.
>
> So... that means we need to add a line in the FILE bucket stuff:
>
>     nbytes += flen;
>
> That should allow us to key on nbytes like you suggest.

This was my first approach.  It ends up triggering a few asserts later on,
because of how we call sendfile_it_all.  It ends up being easier to just
do the addition in the if statement.

> Note that the last conditional is fine *IFF* you also check nbytes.

Yep.  Which is what I did.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message