httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Graham Leggett <minf...@sharp.fm>
Subject Re: [PATCH] option 2: backout changes that cause 'no headers'
Date Wed, 30 May 2001 22:49:07 GMT
sterling wrote:

> Since there needs to be some design work to figure out the best place to
> insert the header filters, i suggest we backout the change that inserts
> them in the 'insert filters' phase -

The HTTP_HEADER filter needs to be inserted last - any filter that ends
up being run after the HTTP_HEADER filter will be completely
ineffective.

The last opportunity to add a filter before the handlers are run is in
the insert_filter phase.

As a result, I conclude that the correct fix for this is the original
insert_filter patch.

As to the missing-headers-on-error problem, the current behavior is to
assume that the filters will be correctly set up when ap_die() is
called. This of course is bogus - when there is an error condition you
cannot assume anything.

As a result, I conclude that the correct fix is to add the
filter-is-there check in ap_die().

So far there has been no opinions yet on this issue - possibly because
of the Memorial Day weekend (I'm in the UK, so I'm not sure) - but if
there are no objections, I would like to apply the insert_filter
HTTP_HEADER fix + the ap_die() filter fix tomorrow morning. 

Regards,
Graham
-- 
-----------------------------------------
minfrin@sharp.fm		"There's a moon
					over Bourbon Street
						tonight..."
Mime
View raw message