httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Havard" <bri...@kheldar.apana.org.au>
Subject Re: DAV build
Date Sun, 20 May 2001 16:29:46 GMT
On Sun, 20 May 2001 18:02:19 +1000 (EST), Brian Havard wrote:

>At the moment --enable-mods-shared=most causes mod_dav to get built shared 
>but mod_dav_fs gets built static. The below change fixes it for me so both 
>get built shared but I'm not certain it will always be right, especially 
>considering this isn't the first attempt to fix this....
>
>Index: config6.m4
>===================================================================
>RCS file: /home/cvs/httpd-2.0/modules/dav/fs/config6.m4,v
>retrieving revision 1.3
>diff -u -r1.3 config6.m4
>--- config6.m4	2001/05/18 20:27:45	1.3
>+++ config6.m4	2001/05/20 07:55:57
>@@ -7,7 +7,7 @@
> if test "$enable_dav" = "no"; then
>   dav_fs_enable=no
> else
>-  dav_fs_enable="$enable_dav"
>+  dav_fs_enable="$dav_enable"
> fi
> 
> APACHE_MODULE(dav_fs, DAV provider for the filesystem, $dav_fs_objects, , $dav_fs_enable)

Nope, that doesn't do it. It doesn't work right if using --enable-dav 
explicitly. Getting the right behaviour in all situations I tested required 
the patch below. Is there any good reason why we can't combine these into one
module? That would simplify things a great deal.


Index: config6.m4
===================================================================
RCS file: /home/cvs/httpd-2.0/modules/dav/fs/config6.m4,v
retrieving revision 1.3
diff -u -r1.3 config6.m4
--- config6.m4	2001/05/18 20:27:45	1.3
+++ config6.m4	2001/05/20 16:27:38
@@ -7,7 +7,15 @@
 if test "$enable_dav" = "no"; then
   dav_fs_enable=no
 else
-  dav_fs_enable="$enable_dav"
+  dav_fs_enable=most
+
+  if test -z "$enable_dav_fs"; then
+    if test -z "$enable_dav"; then
+      enable_dav_fs="shared"
+    else
+      enable_dav_fs="$enable_dav"
+    fi
+  fi
 fi
 
 APACHE_MODULE(dav_fs, DAV provider for the filesystem, $dav_fs_objects, , $dav_fs_enable)

-- 
 ______________________________________________________________________________
 |  Brian Havard                 |  "He is not the messiah!                   |
 |  brianh@kheldar.apana.org.au  |  He's a very naughty boy!" - Life of Brian |
 ------------------------------------------------------------------------------


Mime
View raw message