httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: 1.3 cvs ab ssl fooness
Date Thu, 10 May 2001 15:21:14 GMT
On Thu, May 10, 2001 at 10:23:54AM -0400, Jeff Trawick wrote:
> Joe Orton <jorton@redhat.com> writes:
...
> > @@ -1638,8 +1638,6 @@
> >  	    heartbeatres = 100;	/* but never more often than once every 100
> >  				 * connections. */
> >      }
> > -    else
> > -	heartbeatres = 0;
> 
> Why?  (but the variable heartbeatres is pretty goofy; it is set to 100
> at startup but is mostly a flag that says we want heartbeat messages
> until we then recalculate what we think it should be)

Yeah, 
 
> Can't we just back up to the prior level of ab?  It was a big
> distraction once the new function was committed to 2.0 to actually get
> it to compile properly and stop dumping core.  Obviously nobody has
> had the time/inclination yet to do the same stuff with 1.3 ab.
> 
> (nothing against your patch, Joe; I just wonder what is left untested)

I'd agree, I expect some of the compiler warnings will turn into errors
on some platforms...

joe

Mime
View raw message