Return-Path: Delivered-To: apmail-new-httpd-archive@apache.org Received: (qmail 44589 invoked by uid 500); 4 Apr 2001 17:18:42 -0000 Mailing-List: contact new-httpd-help@apache.org; run by ezmlm Precedence: bulk Reply-To: new-httpd@apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list new-httpd@apache.org Received: (qmail 44575 invoked from network); 4 Apr 2001 17:18:42 -0000 Date: Wed, 4 Apr 2001 10:20:24 -0700 (PDT) From: X-Sender: To: , "William A. Rowe, Jr." Subject: Re: Yuck 2.0.16 signals.c In-Reply-To: <005701c0bd28$0889bd40$2701000a@roweclan.net> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N On Wed, 4 Apr 2001, William A. Rowe, Jr. wrote: > Folks, > > checked out APACHE_2_0_16 and grabbed the apache-2_0_16.tar.gz file tonight... > > > --- srclib\apr\threadproc\unix\signals.c Wed Apr 04 01:35:49 2001 > +++ ..\httpd-2.0\srclib\apr\threadproc\unix\signals.c Tue Apr 03 23:35:52 2001 > @@ -321,10 +321,10 @@ > sigset_t sig_mask; > int rv; > > - /* All threads should mask signals out, accoring to sigwait(2) man page */ > + /* All threads should mask signals out, according to sigwait(2) man page */ > sigfillset(&sig_mask); > > -#if !APR_HAS_THREADS || defined(SIGPROCMASK_SETS_THREAD_MASK) > +#if defined(SIGPROCMASK_SETS_THREAD_MASK) > rv = sigprocmask(SIG_SETMASK, &sig_mask, NULL); > #else > if ((rv = pthread_sigmask(SIG_SETMASK, &sig_mask, NULL)) != 0) { > > > WTF? I trusted the tarball and used that copy for the win32 zip ball, available > now. Look at the file itself. That was inside a #if APR_HAS_THREADS section. In other words, the !APR_HAS_THREADS was kind of bogus. Ryan _______________________________________________________________________________ Ryan Bloom rbb@apache.org 406 29th St. San Francisco, CA 94131 -------------------------------------------------------------------------------