Return-Path: Delivered-To: apmail-new-httpd-archive@apache.org Received: (qmail 2891 invoked by uid 500); 26 Apr 2001 12:52:35 -0000 Mailing-List: contact new-httpd-help@apache.org; run by ezmlm Precedence: bulk Reply-To: new-httpd@apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list new-httpd@apache.org Received: (qmail 2873 invoked from network); 26 Apr 2001 12:52:33 -0000 Sender: jfclere@vtxrm2.bcn.fsc.net Message-ID: <3AE81D0C.244D4732@fujitsu-siemens.com> Date: Thu, 26 Apr 2001 15:05:16 +0200 From: jean-frederic clere X-Mailer: Mozilla 4.72 [en] (X11; I; Linux 2.4.0 i586) X-Accept-Language: en MIME-Version: 1.0 To: new-httpd@apache.org Subject: Re: [STATUS] (apache-1.3) Wed Apr 25 23:45:04 EDT 2001 References: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N Jeff Trawick wrote: > > Blue Lang writes: > > > On Wed, 25 Apr 2001, Rodent of Unusual Size wrote: > > > > > RELEASE NON-SHOWSTOPPERS BUT WOULD BE REAL NICE TO WRAP THESE UP: > > > > > > * htpasswd.c and htdigest.c use tmpnam()... consider using > > > mkstemp() when available. > > > Message-ID: > > > Status: > > > > there have been a couple of patches out there to deal with this.. were > > there problems with them? will they only be accepted if they work on 1.3 > > and 2.0? > > IMHO, for 2.0 what we need is an APR function (or a special > apr_file_open() flag) which creates a temporary file according to the > needs of the platform (probably it uses mkstemp() on Unix) and returns > an APR representation of the file. There is a mktemp.c (for apr_mkstemp()) in APR, well it need more documentations and may be testing ;=). > > This would fit in well with htdigest which already uses APR file I/O. > htpasswd uses stdio, for better or for worse. > > I have no strong opinion for 1.3, but: I don't think mkstemp exists on > all supported platforms, the use of mkstemp()-created files with stdio > may not be portable across all supported platforms, and there is no > APR to handle any nuances, so I suspect the 1.3 apps would get a > little uglier and a little less stable (i.e., might break on some > platforms). > -- > Jeff Trawick | trawickj@bellsouth.net | PGP public key at web site: > http://www.geocities.com/SiliconValley/Park/9289/ > Born in Roswell... married an alien...