Return-Path: Delivered-To: apmail-new-httpd-archive@apache.org Received: (qmail 51108 invoked by uid 500); 11 Apr 2001 16:59:41 -0000 Mailing-List: contact new-httpd-help@apache.org; run by ezmlm Precedence: bulk Reply-To: new-httpd@apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list new-httpd@apache.org Received: (qmail 51090 invoked from network); 11 Apr 2001 16:59:39 -0000 Sender: harrie@lisanza.net Message-ID: <3AD48D8F.6313BD21@covalent.net> Date: Wed, 11 Apr 2001 19:00:00 +0200 From: Harrie Hazewinkel Organization: Covalent Technologies X-Mailer: Mozilla 4.73 [en] (X11; I; FreeBSD 4.1-RELEASE i386) X-Accept-Language: en MIME-Version: 1.0 To: new-httpd@apache.org Subject: Re: [PATCH] mpm_query References: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N rbb@covalent.net wrote: > > On Wed, 11 Apr 2001, dean gaudet wrote: > > > On Wed, 11 Apr 2001 rbb@covalent.net wrote: > > > > > On Wed, 11 Apr 2001, Harrie Hazewinkel wrote: > > > > > > > + /* The MPM types below should actually a string which enables better identification */ > > > > + #define AP_MPMQ_BEOS 1 /* MPM:Beos */ > > > > + #define AP_MPMQ_PERCHILD 2 /* MPM:perchild */ > > > > + #define AP_MPMQ_PREFORK 3 /* MPM:prefork */ > > > > + #define AP_MPMQ_SPMT_OS2 4 /* MPM:spmt_os2 */ > > > > + #define AP_MPMQ_WINNT 5 /* MPM:winnt */ > > > > + #define AP_MPMQ_THREADED 6 /* MPM:threaded */ > > > > > > I dislike this. The Modules shouldn't care which MPM they are running on. > > > Why do we need this option? This option could be of interest to operators. With they could see what kind of MPM a perticular server in a server-farm uses. The way you retrieve this could be via a status page, SNMP, and others. > > > > not to mention that it should be a string based query instead of > > hard-coded integers... otherwise it requires patching every time a new MPM > > is added, which is wrong. > > I agree. Of course, a string would require a new query function, because > the current one always returns an int. Or, we could abstract it out to > return a void *. Like my comment said. I just mapped it to an integer otherwise the mpm_query should change too. It was a work-around based on the current mpm_query, but a string is way better. If we would change it into a 'void *' we maybe need also a length parameter. Just to check whether the caller provides enough space to return the value (int, string, etc..) harrie -- phone: +39-3474932300 http://www.lisanza.net/