httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From <...@covalent.net>
Subject Re: cvs commit: httpd-proxy/module-2.0 proxy_util.c
Date Wed, 25 Apr 2001 17:12:51 GMT

> > orlikowski    01/04/23 19:50:19
> >
> >   Modified:    module-2.0 proxy_util.c
> >   Log:
> >   Just for the sake of cleanliness ...
>
> ??? this patch changes what is passed from NULL to the address of a
> variable set to zero - is that intended?

This is definately what was intended.  The original code should have
caused a seg fault.

Ryan

> >
> >   Revision  Changes    Path
> >   1.56      +2 -1      httpd-proxy/module-2.0/proxy_util.c
> >
> >   Index: proxy_util.c
> >   ===================================================================
> >   RCS file: /home/cvs/httpd-proxy/module-2.0/proxy_util.c,v
> >   retrieving revision 1.55
> >   retrieving revision 1.56
> >   diff -u -r1.55 -r1.56
> >   --- proxy_util.c      2001/04/23 21:03:39     1.55
> >   +++ proxy_util.c      2001/04/24 02:50:19     1.56
> >   @@ -1087,6 +1087,7 @@
> >    {
> >        apr_bucket *e;
> >        apr_status_t rv;
> >   +    apr_size_t zero = 0;
> >        char *pos = buff;
> >        char *response;
> >        int found = 0;
> >   @@ -1100,7 +1101,7 @@
> >        while (!found) {
> >
> >         /* get brigade from network one line at a time */
> >   -     if (APR_SUCCESS != (rv = ap_get_brigade(c->input_filters, bb, AP_MODE_BLOCKING,
0))) {
> >   +     if (APR_SUCCESS != (rv = ap_get_brigade(c->input_filters, bb, AP_MODE_BLOCKING,
&zero))) {
> >             return rv;
> >         }
> >
> >
> >
> >
>
> --
> http://www.apache-ssl.org/ben.html
>
> "There is no limit to what a man can do or how far he can go if he
> doesn't mind who gets the credit." - Robert Woodruff
>
> ApacheCon 2001! http://ApacheCon.com/
>
>


_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message