httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From <...@covalent.net>
Subject Re: [PATCH] ap_f*
Date Thu, 12 Apr 2001 19:02:28 GMT

Looks good.  You missed two functions in util_filter.c, but I have them in
my patch.  Committing in a few minutes.

Ryan

On Thu, 12 Apr 2001, Ryan Morgan wrote:

>
> I think there is a problem with the ap_f* wrappers in httpd.  If the flush
> function is invoked from within apr_brigade_write, we end up skipping over
> a filter.
>
> The ap_f* fuctions are defined as:
>
> #define ap_fputs(f, bb, str) \
>     apr_brigade_puts(bb, ap_filter_flush, (f)->next, str)
>
> If we decide to flush from within apr_brigade_write, ap_filter_flush is
> called with f->next, causing f->next->next to be the next filter to run.
> (skipping over f->next).
>
> A small patch is attached,
>
> Thanks,
>
> -Ryan
>


_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message