httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From <...@covalent.net>
Subject Re: [PATCH] mpm_query
Date Wed, 11 Apr 2001 16:44:57 GMT

> > + /* The MPM types below should actually a string which enables better identification
*/
> > + #define AP_MPMQ_BEOS               1    /* MPM:Beos                   */
> > + #define AP_MPMQ_PERCHILD           2    /* MPM:perchild               */
> > + #define AP_MPMQ_PREFORK            3    /* MPM:prefork                */
> > + #define AP_MPMQ_SPMT_OS2           4    /* MPM:spmt_os2               */
> > + #define AP_MPMQ_WINNT              5    /* MPM:winnt                  */
> > + #define AP_MPMQ_THREADED           6    /* MPM:threaded               */
>
> I dislike this.  The Modules shouldn't care which MPM they are running on.
> Why do we need this option?  Other than that, the patch looks good.  Could
> oyu please generate unified patches from now on, they are much easier to
> debug.

s/debug/review

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message