httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From <...@covalent.net>
Subject Re: Yuck 2.0.16 signals.c
Date Wed, 04 Apr 2001 17:20:24 GMT
On Wed, 4 Apr 2001, William A. Rowe, Jr. wrote:

> Folks,
>
>   checked out APACHE_2_0_16 and grabbed the apache-2_0_16.tar.gz file tonight...
>
>
> --- srclib\apr\threadproc\unix\signals.c Wed Apr 04 01:35:49 2001
> +++ ..\httpd-2.0\srclib\apr\threadproc\unix\signals.c Tue Apr 03 23:35:52 2001
> @@ -321,10 +321,10 @@
>      sigset_t sig_mask;
>      int rv;
>
> -    /* All threads should mask signals out, accoring to sigwait(2) man page */
> +    /* All threads should mask signals out, according to sigwait(2) man page */
>      sigfillset(&sig_mask);
>
> -#if !APR_HAS_THREADS || defined(SIGPROCMASK_SETS_THREAD_MASK)
> +#if defined(SIGPROCMASK_SETS_THREAD_MASK)
>      rv = sigprocmask(SIG_SETMASK, &sig_mask, NULL);
>  #else
>      if ((rv = pthread_sigmask(SIG_SETMASK, &sig_mask, NULL)) != 0) {
>
>
> WTF?  I trusted the tarball and used that copy for the win32 zip ball, available
> now.

Look at the file itself.  That was inside a #if APR_HAS_THREADS section.
In other words, the !APR_HAS_THREADS was kind of bogus.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message