httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul J. Reder" <>
Subject Re: [PATCH] mod_include incorrect function table offset
Date Fri, 20 Apr 2001 21:50:35 GMT
Rob and Karen,

I am a strong -1 on this patch. The code in find_end_sequence computes the
ctx->directive_length. That is the length of the SSI directive only, not the
whole SSI tag (which is stored in ctx->tag_length. This allows the full tag
to be parsed once, marking important indexes as it goes so that I don't need
to do things like recount the size of the directive. If there is any problem
in the code, I would prefer to fix it in the find_end_sequence function.

This is working fine on all of the platforms that I have been testing on. What
system are you developing/testing on? My guess is that either you have a 
c library problem on your system, or the SSI tag that you are testing with has
some parse error in it.

Could you tell me what system you are testing this on and show me the SSI tag
that you are testing with? I would also like to see the error log associated
with trying to process it. 


Paul J. Reder
"The strength of the Constitution lies entirely in the determination of each
citizen to defend it.  Only if every single citizen feels duty bound to do
his share in this defense are the constitutional rights secure."
-- Albert Einstein

View raw message