httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Harrie Hazewinkel <har...@covalent.net>
Subject Re: [PATCH] mpm_query_2
Date Thu, 12 Apr 2001 15:25:01 GMT
rbb@covalent.net wrote:
> 
> On Thu, 12 Apr 2001, Harrie Hazewinkel wrote:
> 
> > Hi all,
> >
> > I have made a new patch for the mpm_query functionality.
> >
> > 1) This patch extends the information that can be retrieved.
> > 2) It also allows to return an MPM_TYPE which is a string.
> >       This is used to provide some additional information
> >       about the MPM used. It even could be used by an MPM
> >       developper to provide an arbitrary human readable
> >       string which can be used for management purposes.
> 
> -1 for returning the string from this function.  It makes the function
> harder to read and to use.  If you absolutely must have a way to query the
> MPM name, then use a separate function for it.  Something like
> ap_show_mpm() like Sander suggested yesterday.

You definitly have not understood the use of it.
But that does not matter. I know you act like the APACHE
2.0 police.

I now start thinking that the MPM_TYPE should be an MPM_DESCR.
and for what the ap_show_mpm goes it can use the mpm_query to
provide the proper values. IMHO, the ap_show_mpm
is a not wrapper around ap_mpm_query.

> 
> > 3) The AP_MPMQ_IS_FORKED and AP_MPMQ_ISTHREADED now return
> >       a capability. It now can return 3 values:
> >                 - NOT_SUPPORTED = 0
> >                 - STATIC = 1
> >                 - DYNAMIC = 2
> >       This mechanism is to enable other module to figure
> >       out the capabilities for threading and forking.
> >       If one wants to have the same results as previous
> >       (which was not more then a true/false) you can
> >       consider value 0 (not supported) as false and
> >       static and dyniamc true.
> >       There is actually no need to make even a capabilities
> >       value besides the IS_FORKED and IS_THREADED.
> 
> I like this section.  I'll commit it today if I have the time to rip out
> the string handling.

-1 on taking out the string section.

> 
> Ryan
> 
> _______________________________________________________________________________
> Ryan Bloom                              rbb@apache.org
> 406 29th St.
> San Francisco, CA 94131
> -------------------------------------------------------------------------------

-- 
phone: +39-3474932300
http://www.lisanza.net/


Mime
View raw message