httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Harrie Hazewinkel <har...@covalent.net>
Subject Re: [PATCH] mpm_query
Date Wed, 11 Apr 2001 17:00:00 GMT
rbb@covalent.net wrote:
> 
> On Wed, 11 Apr 2001, dean gaudet wrote:
> 
> > On Wed, 11 Apr 2001 rbb@covalent.net wrote:
> >
> > > On Wed, 11 Apr 2001, Harrie Hazewinkel wrote:
> > >
> > > > + /* The MPM types below should actually a string which enables better
identification */
> > > > + #define AP_MPMQ_BEOS               1    /* MPM:Beos                
  */
> > > > + #define AP_MPMQ_PERCHILD           2    /* MPM:perchild            
  */
> > > > + #define AP_MPMQ_PREFORK            3    /* MPM:prefork             
  */
> > > > + #define AP_MPMQ_SPMT_OS2           4    /* MPM:spmt_os2            
  */
> > > > + #define AP_MPMQ_WINNT              5    /* MPM:winnt               
  */
> > > > + #define AP_MPMQ_THREADED           6    /* MPM:threaded            
  */
> > >
> > > I dislike this.  The Modules shouldn't care which MPM they are running on.
> > > Why do we need this option?

This option could be of interest to operators. With they could see
what kind of MPM a perticular server in a server-farm uses.
The way you retrieve this could be via a status page, SNMP, and others.

> >
> > not to mention that it should be a string based query instead of
> > hard-coded integers... otherwise it requires patching every time a new MPM
> > is added, which is wrong.
> 
> I agree.  Of course, a string would require a new query function, because
> the current one always returns an int.  Or, we could abstract it out to
> return a void *.

Like my comment said. I just mapped it to an integer otherwise
the mpm_query should change too. It was a work-around based on the
current mpm_query, but a string is way better.

If we would change it into a 'void *' we maybe need also a length
parameter. Just to check whether the caller provides enough space
to return the value (int, string, etc..)
harrie
-- 
phone: +39-3474932300
http://www.lisanza.net/

Mime
View raw message