httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Graham Leggett <>
Subject Re: [PATCH] bugfix in http_filter()
Date Mon, 09 Apr 2001 22:28:06 GMT wrote:

> Yes, it is a waste, but it actually ends up to be a bit cheaper than
> checking for it.  Most modules can just ignore if it is a blank bucket.
> At least, that was the decision when the code was written.

Hmmm... ok. But still - the example code I started working with in
mod_proxy had various apr_bucket_read() functions that assumed the first
bucket returned would have the first bit of the returned string, which
if short enough (eg "HTTP/1.1 200 OK") would be assumed to have arrived
in a single bucket. Trouble is, the first bucket can be empty, which
isn't intuitive. How about adding a warning comment in the code that
empty buckets are possible and should be specifically handled?

-----------------------------------------		"There's a moon
					over Bourbon Street

View raw message