httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Graham Leggett <minf...@sharp.fm>
Subject Re: [PATCH] mod_proxy Keepalives
Date Mon, 02 Apr 2001 17:24:17 GMT
Greg Stein wrote:

> I'd be most interested in understanding how the proxy-outbound filters you
> are using (I forgot the list) are tied to the conn_rec. If we can discover
> how they are tied, then we can get them fixed.

The first filter reads from the network - off a socket stored in a
conn_rec. The other filters are CORE, CORE_IN, HTTP_IN and DECHUNK.

> Summary: for expediency, I can see how you may want to use a conn_rec. But
> please recognize and (I hope) make it a long-term goal to remove them.

I don't see why this should happen - both the standard existing
connection (client -> proxy) and the proxy connection (proxy -> server)
have almost identical needs, such as client_socket, remote_addr,
local_addr, hostname, keepalive, keepalives, keptalive, etc etc. Those
fields we don't need we ignore. Coming up with a new structure and
duplicating the filters just adds more code and more work for us.

I agree though that it would be good to decouple the filters from the
request_rec structure, as we currently have to knock up a skeleton
request_rec structure to get the DECHUNK filter to work, and to use
ap_getline().

Regards,
Graham
-- 
-----------------------------------------
minfrin@sharp.fm		"There's a moon
					over Bourbon Street
						tonight..."

Mime
View raw message