httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: httpd-proxy/module-2.0 proxy_ftp.c
Date Tue, 10 Apr 2001 11:48:32 GMT
On Tue, Apr 10, 2001 at 11:06:13AM +0200, Graham Leggett wrote:
> Greg Stein wrote:
> 
> > ap_getline is bogus and broken for a few reasons. At the hackathon, we
> > discussed creating apr_brigade_getline and apr_brigade_pgetline. When those
> > are built, you should have a much better way to fetch lines.
> > 
> > When? Foo... in a few weeks, I'd guess. Hmm. I'll go add a STATUS item.
> 
> To fix this I wrote a function in proxy_util.c called
> ap_proxy_string_read() - can it not be hacked to your needs?

I'll look at that and at ap_getline to synthesize apr_brigade_(p)getline.
The ap_getline stuff has been seriously hacked on to ensure its correctness.
For example: working on EBCDIC systems.

In any case: your implementation will be a handy input.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message