httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <ad...@rowe-clan.net>
Subject Re: [PATCH] mpm_query
Date Wed, 11 Apr 2001 18:13:53 GMT
From: <rbb@covalent.net>
Sent: Wednesday, April 11, 2001 11:37 AM


> On Wed, 11 Apr 2001, Harrie Hazewinkel wrote:
> 
> > HI,
> >
> > Attached is a patch that enables the mpm_query function
> > to return more information. It returns for instance,
> > the HARD_SERVER_LIMIT and HARD_THREAD_LIMIT.
> >
> > Note: I only was able to test it in the preforked
> > MPM, due to my system I guess.
> >       apr_procattr_t *attr,
> >       apr_pool_t *p);
> >
> > + /* The MPM types below should actually a string which enables better identification
*/
> > + #define AP_MPMQ_BEOS               1    /* MPM:Beos                   */
> > + #define AP_MPMQ_PERCHILD           2    /* MPM:perchild               */
> > + #define AP_MPMQ_PREFORK            3    /* MPM:prefork                */
> > + #define AP_MPMQ_SPMT_OS2           4    /* MPM:spmt_os2               */
> > + #define AP_MPMQ_WINNT              5    /* MPM:winnt                  */
> > + #define AP_MPMQ_THREADED           6    /* MPM:threaded               */
> 
> I dislike this.  The Modules shouldn't care which MPM they are running on.
> Why do we need this option?  Other than that, the patch looks good.  Could
> oyu please generate unified patches from now on, they are much easier to
> debug.

Let us assume for a moment that it's completely proper.

Since 3rd parties will possibly introduce mpm's, can we do this with a string
instead of a number pool we must mangle^H^H^H^H^H^Hmanage?

Bill


Mime
View raw message