Mailing-List: contact new-httpd-help@apache.org; run by ezmlm
Precedence: bulk
Reply-To: new-httpd@apache.org
Sender: trawick@bellsouth.net
To: new-httpd@apache.org
Subject: Re: cvs commit: apache-1.3/src/main http_main.c
References: <20010302123559.60216.qmail@apache.org>
	<m3itlstj7k.fsf@adsl-77-241-65.rdu.bellsouth.net>
	<20010302165156.A99019@deejai2.mch.fsc.net>
From: Jeff Trawick <trawickj@bellsouth.net>
Date: 02 Mar 2001 14:14:26 -0500
In-Reply-To: <20010302165156.A99019@deejai2.mch.fsc.net>
Message-ID: <m366hst23x.fsf@adsl-77-241-65.rdu.bellsouth.net>
Lines: 25
User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/20.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

Martin Kraemer <Martin.Kraemer@Fujitsu-Siemens.com> writes:

> On Fri, Mar 02, 2001 at 08:05:03AM -0500, Jeff Trawick wrote:
> > 
> > So maybe it avoids a segfault, but now we have a configured listening
> > socket we won't wake up for.  Which is worse?  Perhaps segfault is
> > better? (actually, I'd rather us report the error and terminate)
> 
> Flame bait: assert(fd >= 0); ...

or bail out in make_sock() like other errors (if it is an error, of
course; I still don't understand)

> Hmmm... Perhaps we should ask the authors of mod_ssl and KAME.

You committed it, Martin; I'm asking you what problem it solves :)

(I saw a similar change with no comments in the mod_ssl patch; I
didn't see it in the KAME patch I have (for Apache 1.3.6).)

I'll ask Ralf.
-- 
Jeff Trawick | trawickj@bellsouth.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...