httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeffrey W. Baker" <jwba...@acm.org>
Subject Re: [PATCH] update to ap_unparse_uri_components()
Date Thu, 01 Mar 2001 15:17:06 GMT
On Thu, 1 Mar 2001, Martin Kraemer wrote:

> On Wed, Feb 28, 2001 at 03:49:14PM -0800, Jeffrey W. Baker wrote:
> > Please add this latest patch to the Apache 1.3 tree.  It fixes two
> > failures in the current 1.3.19 candidate:
> >
> > 1) the URI "#frag" would be emitted as "", because of a NULL path
> > 2) sometimes an "@" was present in the site part even in the absence of
> > user info
> >
>
> Thanks (for both the patch and the test suite).
>
> I wonder if case 1) and 2) can occur in real-world apache use.
> Though I am with you that the error should be fixed, I think 1.3.19
> is not at risk without the fix. Or what do you think?

I agree.  Case 1 is something that I bet nobody is programmatically
generating, and case 2 is technically a valid URI.  No risk to 1.3.19.

-jwb


Mime
View raw message