httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David McCreedy" <mccre...@us.ibm.com>
Subject Re: [PATCH] EBCDIC: Configurable Conversion Cleanup (Part 1)
Date Sat, 03 Mar 2001 00:54:54 GMT

I finally had a chance to test out Apache with the new EBCDIC patches
applied.
Thanks Martin for doing all this work... it runs fine on TPF.
I do have a few questions before the patches get committed:

1)  Since the processing of EBCDICKludge in main/http_core.c is wrapped in
an "#ifdef LEGACY_KLUDGE", should the directive itself be wrapped by the
same #ifdef so it only shows up as a valid directive if the server was
compiled with LEGACY_KLUDGE defined?

2) In main/http_protocol.c it looks like you deleted the start of the
comment line but not the end (look for the "@@ -1322,8 +1328,8 @@"
section).  It's probably just how I'm reading the diff.

3)  The EBCDIC tables in os/os390/ebcdic.c and os/tpf/ebcdic.c were defined
as const. But in ap/ap_ebcdic.c the tables are "const" only if it's not
OS390 and not TPF.  Was this intended or accidental?  In order to add the
"const" back to the tables in ap/ap_ebcdic.c I also had to add it to
include/ap_ebcdic.h, otherwise it caused a compiler error.

And a request...

I've update the text files in os/tpf/samples, in part due to these ebcdic
patches.
I'd like to

     - remove os/tpf/samples/linkdll.jcl
     - add os/tpf/samples/linkhttp.jcl
     - replace os/tpf/samples/loadset.jcl

This would be wholesale replacements, so I've attached the complete files
(versus diffs) to this email.
Can you commit these along with your changes or should they go through a
separate review?

-David McCreedy
McCreedy@us.ibm.com


(See attached file: loadset.jcl)(See attached file: linkhttp.jcl)


Martin Kraemer <Martin.Kraemer@Fujitsu-Siemens.com> on 02/09/2001 03:18:33
AM

Please respond to new-httpd@apache.org

To:   new-httpd@apache.org
cc:
Subject:  [PATCH] EBCDIC: Configurable Conversion Cleanup (Part 1)



On Wed, Feb 07, 2001 at 10:37:17PM +0100, Martin Kraemer wrote:
> * make EBCDIC conversion truly configurable. [...]
>
> * make EBCDIC conversion symmetric. [...]
>
> * unify the EBCDIC tables to be in a single common file [...]

Here is part 1 of my patch.

    Martin
--
<Martin.Kraemer@Fujitsu-Siemens.com>    |       Fujitsu Siemens
       <martin@apache.org>              |   81730  Munich,  Germany




Mime
View raw message