httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Kraemer <Martin.Krae...@Fujitsu-Siemens.com>
Subject Re: [PATCH] EBCDIC: Configurable Conversion Cleanup (Part 1)
Date Fri, 09 Mar 2001 10:00:52 GMT
On Fri, Mar 02, 2001 at 05:54:54PM -0700, David McCreedy wrote:
> 
> I finally had a chance to test out Apache with the new EBCDIC patches
> applied.

Thanks for reviewing them. I have a better feeling if another
EBCDIC user has had at least a glance.

> 1)  Since the processing of EBCDICKludge in main/http_core.c is wrapped in
> an "#ifdef LEGACY_KLUDGE", should the directive itself be wrapped by the
> same #ifdef so it only shows up as a valid directive if the server was
> compiled with LEGACY_KLUDGE defined?

Good point. Added.

> 2) In main/http_protocol.c it looks like you deleted the start of the
> comment line but not the end (look for the "@@ -1322,8 +1328,8 @@"
> section).  It's probably just how I'm reading the diff.

Looks okay to me: the "*/" was in a line which did not change.

> 3)  The EBCDIC tables in os/os390/ebcdic.c and os/tpf/ebcdic.c were defined
> as const. But in ap/ap_ebcdic.c the tables are "const" only if it's not
> OS390 and not TPF.  Was this intended or accidental?  In order to add the
> "const" back to the tables in ap/ap_ebcdic.c I also had to add it to
> include/ap_ebcdic.h, otherwise it caused a compiler error.

Thanks for pointing this out. I totally forgot about the const in
ap_ebcdic.h. And about the tables: A while ago there was some patch
on the list which automatically initialized the table based on the
currently selected EBCDIC dialect. I think it was written for OS390.
As it was not integrated (and would also cause problems because the
compiled-in strings are not updated when loading a different table)
you are completely right: the const has to go back in. Done.

> And a request...
> 
> I've update the text files in os/tpf/samples, in part due to these ebcdic
> patches.
> I'd like to
> 
>      - remove os/tpf/samples/linkdll.jcl
>      - add os/tpf/samples/linkhttp.jcl
>      - replace os/tpf/samples/loadset.jcl
> 
> This would be wholesale replacements, so I've attached the complete files
> (versus diffs) to this email.
> Can you commit these along with your changes or should they go through a
> separate review?

Will commit right after my commit.

Thanks again,

   Martin
-- 
<Martin.Kraemer@Fujitsu-Siemens.com>    |       Fujitsu Siemens
       <martin@apache.org>              |   81730  Munich,  Germany

Mime
View raw message