httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Stoddard" <b...@wstoddard.com>
Subject SGI Patch - 10xpatch-2_0a6-6
Date Fri, 16 Mar 2001 04:39:03 GMT
FYI... Mike if you are still reading...
This patch had an interesting optimization to avoid using sscanf to
determine the HTTP protocol numbers which I just committed to Apache 2.0.
This patch also had a lot of extra 'cruft'.  The cruft  (stm.html, et. al.)
made reviewing this patch difficult. Had you submitted the sscanf piece as a
seperate patch, it would have been committed within a few days. As it was,
there was too much for most of us to review in one sitting and there were
multiple changes that were completely unrelated to each other.

Should you decide to submit patches in the future (and i hope you do), I
suggest you keep the entire patch 'on topic' and scoped to accomplish a very
specific purpose.  The smaller the patch, the more likely someone will be
able to grok it in one sitting and make a decision on it. If the reviewer
has to tease out good changes from cruft, they'll just not bother in most
cases. I happen to be a bit of a performance junkie myself which is why I am
spending my time on this.

Bill


Mime
View raw message