Return-Path: Delivered-To: apmail-new-httpd-archive@apache.org Received: (qmail 78907 invoked by uid 500); 13 Feb 2001 18:26:05 -0000 Mailing-List: contact new-httpd-help@apache.org; run by ezmlm Precedence: bulk Reply-To: new-httpd@apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list new-httpd@apache.org Received: (qmail 78874 invoked from network); 13 Feb 2001 18:26:00 -0000 From: Cliff Woolley To: new-httpd@apache.org MMDF-Warning: Parse error in original version of preceding line at mail.virginia.edu Cc: dev@apr.apache.org MMDF-Warning: Parse error in original version of preceding line at mail.virginia.edu Subject: docco problem (was RE: Chunk filter problem?) Date: Tue, 13 Feb 2001 13:25:31 -0500 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook IMO, Build 9.0.2416 (9.0.2911.0) X-MimeOLE: Produced By Microsoft MimeOLE V5.00.2615.200 In-Reply-To: Importance: Normal X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N > -----Original Message----- > Okay, I'm not 100% sure on this, but I think I spotted a problem in the > chunk filter such that two immortal buckets are getting inserted AFTER the > EOS bucket by means of transposed parameters to the > APR_BUCKET_INSERT_BEFORE macro. Okay, I had it the wrong way around, thankfully. It's the documentation that's got it wrong, not the chunk filter. So nix the chunk filter patch, as it's incorrect. Instead, we just need to change the docco in apr_buckets.h in APR-UTIL to reflect reality: Index: apr_buckets.h =================================================================== RCS file: /home/cvspublic/apr-util/include/apr_buckets.h,v retrieving revision 1.73 diff -u -r1.73 apr_buckets.h --- apr_buckets.h 2001/02/11 15:50:10 1.73 +++ apr_buckets.h 2001/02/13 18:21:46 @@ -338,16 +338,16 @@ /** * Insert a list of buckets before a specified bucket - * @param a The buckets to insert - * @param b The bucket to insert before + * @param a The bucket to insert before + * @param b The buckets to be inserted * @deffunc void APR_BUCKET_INSERT_BEFORE(apr_bucket *a, apr_bucket *b) */ #define APR_BUCKET_INSERT_BEFORE(a, b) \ APR_RING_INSERT_BEFORE((a), (b), link) /** * Insert a list of buckets after a specified bucket - * @param a The buckets to insert - * @param b The bucket to insert after + * @param a The bucket to insert after + * @param b The buckets to be inserted * @deffunc void APR_BUCKET_INSERT_AFTER(apr_bucket *a, apr_bucket *b) */ #define APR_BUCKET_INSERT_AFTER(a, b) \ It'd be really nice if the ring macros were documented, as that would have cleared up this confusion pretty quickly (as it was, I had to trace through the ring macros on a whiteboard to make absolutely sure of which way around they were supposed to go). I don't suppose anyone would object if I documented them? =-) --Cliff