Return-Path: Delivered-To: apmail-new-httpd-archive@apache.org Received: (qmail 8614 invoked by uid 500); 16 Feb 2001 21:23:25 -0000 Mailing-List: contact new-httpd-help@apache.org; run by ezmlm Precedence: bulk Reply-To: new-httpd@apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list new-httpd@apache.org Received: (qmail 8578 invoked from network); 16 Feb 2001 21:23:20 -0000 Errors-To: Message-ID: <0b0d01c0985e$a2d4b290$93c0b0d0@roweclan.net> From: "William A. Rowe, Jr." To: References: Subject: Re: [PATCH] Fix 1.3.17 crash in util_uri.c, etc. Date: Fri, 16 Feb 2001 15:22:58 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.50.4133.2400 X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4133.2400 X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N From: "Jeffrey W. Baker" Sent: Friday, February 16, 2001 3:20 PM > > uri_components retptr, > > retptr = *uptr; > > > > Fill in the missing components with a constant empty string, balance the elements > > as you are already doing, and then merging the list of members rather than > > incrementing a string array index through the pieces? > > > > I'm thinking pure legibility here. > > I'll look into it. I wrote the routine this way for two reasons. With > the array, you can easily track the URI being built in a gdb session. > Also, the uri_components structure doesn't have any places for the > delimiters. Correct, :// would have to be appended to the scheme or prepended to the host name with ap_pstrcat, but expected that was the most legible method.