httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <trawi...@bellsouth.net>
Subject Re: cvs commit: httpd-2.0/server util_filter.c
Date Fri, 09 Feb 2001 12:27:17 GMT
rbb@apache.org writes:

> rbb         01/02/08 23:04:52
...
>   Index: util_filter.h
>   ===================================================================
>   RCS file: /home/cvs/httpd-2.0/include/util_filter.h,v
>   retrieving revision 1.38
>   retrieving revision 1.39
>   diff -u -d -b -w -u -r1.38 -r1.39
>   --- util_filter.h	2001/02/03 20:25:13	1.38
>   +++ util_filter.h	2001/02/09 07:04:51	1.39
>   +/**
>   + * Write an unspecified number of strings to the current filter
>   + * @param f the filter to write to
>   + * @param bb The brigade to buffer into
>   + * @param ... The strings to write
>   + * @deffunc int ap_fputs(ap_filter_t *f, apr_bucket_brigade *bb, ...);
>   + */
>   +#define ap_fvputs(f, bb, args...) \
>   +	apr_brigade_putstrs(bb, filter_flush, f->next, ##args)

not portable...

Tru64's compiler says:

> cc: Warning: /home/trawick/regress/httpd-2.0/include/util_filter.h, line 451: Formal
parameter isn't an identifier. (badformalparm)
> #define ap_fvputs(f, bb, args...) \
> -----------------------------^
> cc: Warning: /home/trawick/regress/httpd-2.0/include/util_filter.h, line 462: Formal
parameter isn't an identifier. (badformalparm)
> #define ap_fprintf(f, bb, fmt, args...) \
> -----------------------------------^

(and again every time util_filter.h is included :) )

Besides the warning for the macro definition, an error is generated if
the macro is actually used in the way you intend.

(no idea how to fix with a macro)
-- 
Jeff Trawick | trawickj@bellsouth.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...

Mime
View raw message