httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <trawi...@bellsouth.net>
Subject Re: cvs commit: httpd-2.0/server/mpm/mpmt_pthread mpm.h
Date Wed, 07 Feb 2001 12:27:39 GMT
rbb@covalent.net writes:

> On 6 Feb 2001 trawick@apache.org wrote:
> 
> > trawick     01/02/06 14:23:01
> > 
> >   Modified:    include  scoreboard.h
> >                server/mpm/prefork mpm.h
> >                server/mpm/mpmt_pthread mpm.h
> >   Log:
> >   get Unix MPMs to build again after recent scoreboard changes
> 
> The OS/2 scoreboard changes were incorrect as per my e-mail from earlier
> today.  Ever one of those fields should not be in the common scoreboard
> structure.

Part of my simple changes did indeed keep the unnecessary-for-unix tid
field around.  That doesn't hurt anybody for now; it doesn't make it
harder to back out (delete three consecutive lines instead of one).

The other part of the simple change was to use the declaration of
ap_scoreboard_image in scoreboard.h and dispense with the one in
mpm.h.  That is just neatness, whether or not it is required to get
the server to compile (which it is currently).

Is there anything negative about either of these changes which you'd
like me to be aware of?  AFAICT, it did not interfere with the
dialog between you and Brian, and it did let the rest of us easily
build and run the latest code.

-- 
Jeff Trawick | trawickj@bellsouth.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...

Mime
View raw message