httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeffrey W. Baker" <jwba...@acm.org>
Subject Re: [PATCH] Fix 1.3.17 crash in util_uri.c, etc.
Date Wed, 28 Feb 2001 23:12:35 GMT
On Tue, 27 Feb 2001, dean gaudet wrote:

> On Sat, 10 Feb 2001, Jeffrey W. Baker wrote:
>
> > The new code compiles and runs on Linux 2.4.1/glibs 2.2.1 here at home,
> > passes 80 tests of my own, and passes modules/test/mod_test_util_uri.c.
>
> jwb did you submit your tests as well / were they committed?  'cause it's
> always nice to have the tests.
>
> i should have named mod_test_util_uri.c mod_test_ap_parse_uri_components.c
> ... that's the only function it really tests, it doesn't test the
> unparsing.  that'd be a nice addition though.

Sure.  I did the tests by replacing test_util_uri with my own code :)
Sorry about that but if someone wants to slap this into the build, it
would be pretty easy.  The tests are attached.

BTW I just added some tests and there are three cases where the routine
fails by printing the wrong URI on fairly obscure URIs.  I will submit
another patch in a while.

-jwb

Mime
View raw message