httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From <...@covalent.net>
Subject Re: cvs commit: httpd-2.0/modules/mappers mod_dir.c
Date Wed, 21 Feb 2001 06:45:52 GMT
On Wed, 21 Feb 2001, Greg Stein wrote:

> On Wed, Feb 21, 2001 at 12:37:54AM -0800, Ryan Morgan wrote:
> >
> > I don't think this change is going to work because mod_dir does more
> > than just check if a redirect is going to be needed.  It also handles
> > the sending of index files.  This means that with this change running
> > ap_sub_req_* could result in a index file being sent, which is not the
> > correct behavior.
> >
> > The sending of the index file still needs to be implemented as a handler.
> > I would suggest that we either back this change out, or move the uri
> > checking into to fixups phase to allow subrequests to determine if the
> > request will generate a HTTP_MOVED_PERMANANTLY response.  A patch is
> > attached, only minimally tested since an update of my tree has resulted
> > in undefined references to pthread_sigmask.
>
> Seems fine to me!

I see what was missed now.  There is an internal_redirect() in that
function.  I'll fix this right now.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message