httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeffrey W. Baker" <jwba...@acm.org>
Subject Re: [PATCH] Fix 1.3.17 crash in util_uri.c, etc.
Date Sat, 17 Feb 2001 18:51:23 GMT
On Sat, 17 Feb 2001, Martin Kraemer wrote:

> On Wed, Feb 14, 2001 at 07:56:05AM -0800, Jeffrey W. Baker wrote:
> > > It looks good, although in the line
> > >    29	                uptr->scheme = DEFAULT_URI_SCHEME;
> > > you assign to a "const" structure, and some compilers dislike that.
> > 
> > Ah, you are right I meant to remove that but my versions got out of sync.
> 
> Does that mean: your patch, minus exactly this one line?
> But that breaks the check for the default port further down.
> (uptr->port == ap_default_port_for_scheme(uptr->scheme)))
> although if no scheme is set, the port and per_str are probably
> unset as well?!
> 
> I am unsure, could you please re-submit the cleaned patch?

Attached.  I replaced the loop initializer with memset, and avoided
modifying the const argument by holding the scheme in a local
variable.  Passes local tests and mod_test_util_uri.c.

-jwb

Mime
View raw message