httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: cvs commit: apr-util/buckets apr_buckets_file.c (fwd)
Date Fri, 16 Feb 2001 18:05:19 GMT
On Fri, 16 Feb 2001, Paul J. Reder wrote:

> rbb@covalent.net wrote:
> > 
> > The second problem is one I haven't fixed however.  Brian, if you increase
> > the size of your file to 10Meg, then mod_include will read all 10Meg into
> > memory before sending it down the stack.  That's BAD!  mod_include needs
> > to be taught how to stream data when there are no SSI tags in the file.
> > 
> > I will be adding the second issue to STATUS.  Brian, please test the
> > latest code on OS/2.
> 
> I can work on this. The question is how to decide when to send it on down?
> Should there be a #defined threshold value? System wide or mod_include specific?
> I would assume that as I am parsing through the bucket(s) I just keep track
> of the number of bytes parsed and break/pass the brigade when I cross the
> threshold, yes?

Personally, I would use the same threshold that mod_core uses for
core_output_filter.  This may mean having to move that #define.

Ryan
_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message