httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: cvs commit: httpd-2.0/modules/generators mod_status.c
Date Thu, 15 Feb 2001 18:34:37 GMT

> > > This patch causes core dumps on Linux. In particular the %lld change
> > > causes ap_rprintf -> apr_vrprintf -> apr_vsnprintf -> apr_vformatter
> > > %s processing (line 938) to dump core due to bad results from the
> > > va_arg call (s is non-null garbage, causing strlen to dump).
> > >
> > > Setting it back to %ld seems to work fine and doesn't seem to give me
> > > warnings.

BTW, setting it to %ld gives bad output on my box.

Ryan

> > >
> > > To reproduce this, all I have to do is start Apache (configed as
> > > apache.org is) and try to browse server-status -- core dump!
> > >
> > > >        if (days)
> > > >   -     ap_rprintf(r, " %ld day%s", days, days == 1 ? "" : "s");
> > > >   +     ap_rprintf(r, " %lld day%s", days, days == 1 ? "" : "s");
> > > >        if (hrs)
> > > >   -     ap_rprintf(r, " %ld hour%s", hrs, hrs == 1 ? "" : "s");
> > > >   +     ap_rprintf(r, " %lld hour%s", hrs, hrs == 1 ? "" : "s");
> > > >        if (mins)
> > > >   -     ap_rprintf(r, " %ld minute%s", mins, mins == 1 ? "" : "s");
> > > >   +     ap_rprintf(r, " %lld minute%s", mins, mins == 1 ? "" : "s");
> > > >        if (secs)
> > > >   -     ap_rprintf(r, " %ld second%s", secs, secs == 1 ? "" : "s");
> > > >   +     ap_rprintf(r, " %lld second%s", secs, secs == 1 ? "" : "s");
> > > >    }--
> > > Paul J. Reder
> > > -----------------------------------------------------------
> > > "The strength of the Constitution lies entirely in the determination of
> each
> > > citizen to defend it.  Only if every single citizen feels duty bound to do
> > > his share in this defense are the constitutional rights secure."
> > > -- Albert Einstein
> > >
> > >
> >
> >
> >
> ______________________________________________________________________________
> _
> > Ryan Bloom                        rbb@apache.org
> > 406 29th St.
> > San Francisco, CA 94131
> > ----------------------------------------------------------------------------
> ---
> >
> 
> 


_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message