httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: cvs commit: httpd-2.0/modules/generators mod_status.c
Date Thu, 15 Feb 2001 18:34:07 GMT


This is a time.  We may want to convert those to apr_interval_time_t's
instead of apr_time_t's, but the up_time value (which is what we are
talking about here), is without a doubt a time value.

Ryan

On Thu, 15 Feb 2001, Bill Stoddard wrote:

> Another problem I have (conceptually) with your patch Ryan is that we are
> using apr_time_t to hold values that are -not- apr time. That is the reason I
> used the apr_uint32_t types which your removed (and which removed some compile
> time warnings for me on Windows).  Variables defined as apr_time_t should not
> be used as generic 64 bit storage area.
> 
> Bill
> 
> 
> ----- Original Message -----
> From: <rbb@covalent.net>
> To: <new-httpd@apache.org>
> Sent: Thursday, February 15, 2001 1:09 PM
> Subject: Re: cvs commit: httpd-2.0/modules/generators mod_status.c
> 
> 
> >
> > I am actually in the middle of tracing this down.  The problem I am
> > having, is that apr_time_t is a 64 bit integer, so %lld is correct.  I
> > will commit a fix in the next few minutes.
> >
> > Ryan
> >
> > On Thu, 15 Feb 2001, Paul J. Reder wrote:
> >
> > > Ryan,
> > >
> > > rbb@apache.org wrote:
> > > >
> > > > rbb         01/02/14 16:01:34
> > > >
> > > >   Modified:    modules/generators mod_status.c
> > > >   Log:
> > > >   Remove some warnings from mod_status.
> > > >
> > > >   Revision  Changes    Path
> > > >   1.27      +7 -7      httpd-2.0/modules/generators/mod_status.c
> > > >
> > > >   Index: mod_status.c
> > > >   ===================================================================
> > > >   RCS file: /home/cvs/httpd-2.0/modules/generators/mod_status.c,v
> > > >   retrieving revision 1.26
> > > >   retrieving revision 1.27
> > > >   diff -u -d -b -w -u -r1.26 -r1.27
> > > >   --- mod_status.c      2001/02/14 03:49:17     1.26
> > > >   +++ mod_status.c      2001/02/15 00:01:32     1.27
> > >
> > > This patch causes core dumps on Linux. In particular the %lld change
> > > causes ap_rprintf -> apr_vrprintf -> apr_vsnprintf -> apr_vformatter
> > > %s processing (line 938) to dump core due to bad results from the
> > > va_arg call (s is non-null garbage, causing strlen to dump).
> > >
> > > Setting it back to %ld seems to work fine and doesn't seem to give me
> > > warnings.
> > >
> > > To reproduce this, all I have to do is start Apache (configed as
> > > apache.org is) and try to browse server-status -- core dump!
> > >
> > > >        if (days)
> > > >   -     ap_rprintf(r, " %ld day%s", days, days == 1 ? "" : "s");
> > > >   +     ap_rprintf(r, " %lld day%s", days, days == 1 ? "" : "s");
> > > >        if (hrs)
> > > >   -     ap_rprintf(r, " %ld hour%s", hrs, hrs == 1 ? "" : "s");
> > > >   +     ap_rprintf(r, " %lld hour%s", hrs, hrs == 1 ? "" : "s");
> > > >        if (mins)
> > > >   -     ap_rprintf(r, " %ld minute%s", mins, mins == 1 ? "" : "s");
> > > >   +     ap_rprintf(r, " %lld minute%s", mins, mins == 1 ? "" : "s");
> > > >        if (secs)
> > > >   -     ap_rprintf(r, " %ld second%s", secs, secs == 1 ? "" : "s");
> > > >   +     ap_rprintf(r, " %lld second%s", secs, secs == 1 ? "" : "s");
> > > >    }--
> > > Paul J. Reder
> > > -----------------------------------------------------------
> > > "The strength of the Constitution lies entirely in the determination of
> each
> > > citizen to defend it.  Only if every single citizen feels duty bound to do
> > > his share in this defense are the constitutional rights secure."
> > > -- Albert Einstein
> > >
> > >
> >
> >
> >
> ______________________________________________________________________________
> _
> > Ryan Bloom                        rbb@apache.org
> > 406 29th St.
> > San Francisco, CA 94131
> > ----------------------------------------------------------------------------
> ---
> >
> 
> 


_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message