httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ask Bjoern Hansen <...@valueclick.com>
Subject Re: apxs patch
Date Sat, 10 Feb 2001 12:35:34 GMT
On Sat, 10 Feb 2001, Ralf S. Engelschall wrote:

> > ***************
> > *** 245,251 ****
> >          print STDERR "$cmd\n";
> >          $rc = system("$cmd");
> >          if ($rc != 0) {
> > !             printf(STDERR "apxs:Break: Command failed with rc=%d\n", $rc
> >>> 8)
> > ;
> >              exit(1);
> >          }
> >      }
> > --- 245,251 ----
> > --- 245,251 ----
> >          print STDERR "$cmd\n";
> >          $rc = system("$cmd");
> >          if ($rc != 0) {
> > !             printf(STDERR "apxs:Break: Command failed with rc=%d\n", $rc
> > << 8)
> > ;
> >              exit(1);
> >          }
> >      }
> > ---- CUT HERE ----
> 
> Errr... sorry, I don't understand why this should fix anything.
[...]
> So our ">> 8" is correct while the "<< 8" breaks the code.

That's right. And it doesn't change the program flow anyway (it just
changes (breaks) the warning).

Btw, it would be more perlish written as 


  warn "apxs:Break: Command failed with rc=", $rc >> 8, "\n";

instead of all that printf STDERR foo. :-)



 - ask

-- 
ask bjoern hansen - <http://ask.netcetera.dk/>
more than 70M impressions per day, <http://valueclick.com>


Mime
View raw message